BREAKING CHANGE: incorporated changes planned for v3 #751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporated changes planned for v3 including breaking changes
List of breaking changes that were taken care as part of this major release are:
Credentials
class into a data class as shown here, as a result of which this class can no longer be extended and also propertycurrentTimeInMillis
is removed from it . Fixed unit tests using CredentialsMock.kt with this change as it can no longer extend Credentials class.BaseCredentialsManager
interface with all the overloads of getCredentials & awaitCredentials methods, and now all the implementing classes should override them instead of defining them directly.await()
in the Request.kt here to an abstract function, now all the implementations of it should define the function.List of other changes that were taken care as part of this major release are:
GsonProvider
directly via the internal constructor of DefaultClient as shown here.NetworkErrorException
directly from theErrorAdapter
's inAuthenticationAPIClient
andUsersAPIClient
, so nowAuthenticationException
andManagementException
should just check if the cause isNetworkErrorException
to understand if an error is due to Network Error. Created a Util function to check if a throwable is a network error and added unit tests for it.Testing
This has been tested with all the existing unit tests and with the sample app as well.
Checklist